1418325 - "profile missing or inaccessible" message for users with non-latin characters in path

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[[:philipp]]

[Tracking Requested - why for this release]:
we got reports from multiple users with chinese, cyrillic & hebrew characters in their windows account names (and therefore the path to their userprofile) that after they've update to firefox 57 they get the "profile missing or inaccessible" when they attempt the browser. 

https://support.mozilla.org/en-US/questions/1186764
https://support.mozilla.org/en-US/questions/1186731

i could reproduce the problem when creating a windows account with the usernames referenced in the sumo thread.

Comment 1

[Jim Mathies [:jimm]]

I'll file a pi-request.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

We had similar issues in 55 that we fixed in a dot release. There is an open bug for adding test coverage in this area, bug 1392308.

Comment 3

[[:philipp]]

a report at https://support.mozilla.org/en-US/questions/1187752 is indicating that this may have regressed in 52.5.0esr as well. perhaps related to 1407751?

Comment 4

[Andrea Marchesini [:baku]]

I cannot reproduce it on linux. This seems to be a windows bug only.

Can somebody check if it is reproducible with FF58?
_if_ bug 1407751 is related, it could be that it is already fixed by bug 1416174 on FF58.

Comment 5

[[:philipp]]

the issue still reproduces on 58.0b4

Comment 6

[Emil Ghitta, QA [:emilghitta]]

I can confirm that this issue is reproducible using Chinese, Cyrillic and Hebrew windows account names.

Please note that this issue can be reproduce even by simply running an affected Firefox build (57,58 and 59) and not only by performing an update.

Steps to reproduce:

1. Create and login with a Cyrillic windows account (ex.Администратор).
2. Launch Firefox 57.0.
3. Observe that the error is displayed and Firefox cannot start.

Steps to reproduce using update:

1. Create and login with a Cyrillic windows account (ex.Администратор).
2. Launch Firefox 56.0.2 with a new profile.
3. Update Firefox to 57.0.
4. Observe that the error is displayed and Firefox cannot start.


Last good revision: 92a8b8ce2f728ea5cc4ea8e4d8b3e2c5fe76a9ed
First bad revision: 321e5a4f37b543c73055159b9630621890fc8b4e

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=92a8b8ce2f728ea5cc4ea8e4d8b3e2c5fe76a9ed&tochange=321e5a4f37b543c73055159b9630621890fc8b4e

Florian, can you please have a look into this? Thanks!

Comment 7

[[:philipp]]

52.5.0esr is not affected when i am re-testing it myself now, so comment #3 was a wrong avenue. sorry for that!

Comment 8

[Florian Quèze [:florian]]

(In reply to Emil Ghitta, QA [:emilghitta] from comment #6)
> I can confirm that this issue is reproducible using Chinese, Cyrillic and
> Hebrew windows account names.
> 
> Please note that this issue can be reproduce even by simply running an
> affected Firefox build (57,58 and 59) and not only by performing an update.
> 
> Steps to reproduce:
> 
> 1. Create and login with a Cyrillic windows account (ex.Администратор).
> 2. Launch Firefox 57.0.
> 3. Observe that the error is displayed and Firefox cannot start.

When testing, it always worked for me if C:\Users\Администратор\AppData\Roaming\Mozilla\Firefox\profiles.ini didn't exist. Once that file exists, I can't start Firefox 57 (or a current local build) anymore.

> Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=92a8b8ce2f728ea5cc4ea8e4d8b3e2c5fe76a9ed&tochange=321e
> 5a4f37b543c73055159b9630621890fc8b4e
> 
> Florian, can you please have a look into this? Thanks!

The bug that seems the most obviously related in that range is bug 1372152 (Windows-only code related to getting folder paths). Attempting to backout this patch locally and building didn't help for me though. Still investigating.

Comment 9

[Florian Quèze [:florian]]

Running mozregression gives me this range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d69a6595&tochange=a9a24a28 -> bug 1363482

Comment 10

[Andy McKay]

(In reply to Florian Quèze [:florian] [:flo] from comment #9)
> When testing, it always worked for me if
> C:\Users\Администратор\AppData\Roaming\Mozilla\Firefox\profiles.ini didn't
> exist. Once that file exists, I can't start Firefox 57 (or a current local
> build) anymore.

Confirmed, just touching an empty profiles.ini triggers the bug for me.

Comment 11

[Andy McKay]

(In reply to Andy McKay [:andym] from comment #10)
> (In reply to Florian Quèze [:florian] [:flo] from comment #9)
> > When testing, it always worked for me if
> > C:\Users\Администратор\AppData\Roaming\Mozilla\Firefox\profiles.ini didn't
> > exist. Once that file exists, I can't start Firefox 57 (or a current local
> > build) anymore.
> 
> Confirmed, just touching an empty profiles.ini triggers the bug for me.

Sorry for the spam please ignore this comment, I was doing it wrong.

Comment 12

[Emil Ghitta, QA [:emilghitta]]

Attachment: profiles.ini

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

When a fix is ready and is deemed low risk, we can consider this for inclusion in a  57.x dot release.

Comment 14

[Masatoshi Kimura [:emk]]

I believe my bug 1420427 patch will also fix this.

Comment 15

[[:philipp]]

yes, retesting it with 57.0.1 candidate build 2 apparently fixes the problem described in this bug too. thank you!